Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Fixes for SPR/SPR2 BLAS 2 routines #492

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

pgorlani
Copy link
Contributor

This patch fixes various aspects of the SPR/SPR2 BLAS2 routines:

  • fix the mapping of the global work-item index to the triangular matrix coordinates by using only integer arithmetic;
  • move method definitions to the proper file;
  • remove unnecessary increment arguments;
  • improve unit tests by randomly generating the matrix and removing the unnecessary memory layout argument;
  • improve documentation.

Copy link
Collaborator

@muhammad-tanvir-1211 muhammad-tanvir-1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the comment regarding layout in tests. Thanks.

Copy link
Collaborator

@OuadiElfarouki OuadiElfarouki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@muhammad-tanvir-1211 muhammad-tanvir-1211 merged commit 15fc7be into codeplaysoftware:master Jan 24, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants