Change usage of DEFAULT_CPU TUNING_TARGET to DEFAULT #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjabird
reviewed
May 6, 2024
hjabird
approved these changes
May 7, 2024
Rbiessy
reviewed
May 7, 2024
Rbiessy
approved these changes
May 7, 2024
Using DEFAULT_CPU as TUNING_TARGET for AMD or NVIDIA GPUs let some tests fail. Disabling failing tests for now and output a proper message. Signed-off-by: nscipione <[email protected]>
This tuning target is capable of compiling for every device if DPCPP_SYCL_TARGET and DPCPP_SYCL_ARCH are specified correctly. So this comment is a first step in changing this target behaviour and increasing general understanding.
Running tests on w6800 AMD GPU revails another test failing. Skip this test for now. Signed-off-by: nscipione <[email protected]>
Add possibility of using DEFAULT as target. Explaining how and current operators situation.
The default target is not compatible only with CPU, so renaming files and references from "default_cpu" to "default"
Set a unique variable to decide which tests are skipped according to compiler, tuning target and hardware Signed-off-by: nscipione <[email protected]>
Co-authored-by: HJA Bird <[email protected]>
pgorlani
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
DEFAULT_CPUfrom a CPU specificTUNING_TARGETto a generalDEFAULTone. Using this target allow portBLAS to run on every hardware correctly but at performance expenses.In order to use the
DEFAULTtarget on AMD or NVIDIA users are required to specifyDPCPP_SYCL_TARGETandDPCPP_SYCL_ARCHotherwise the compiler cannot offload the kernel.Right now, some operators don't work correctly consequently those tests are disable for that target.
Tests disabled on AMD GPUs:
Tests disabled on NVIDIA GPUs: