Skip to content

Commit

Permalink
Delete local storage patch
Browse files Browse the repository at this point in the history
The main goal of this patch was to make user settings stored on disk
instead of in the browser, but this stopped working some time ago.  Not
only that but it is causing a bug where a workspace will not fully open.

A secondary goal was to fix the Vim extension but the extension appears
to work just fine without this change now (both the server and browser
versions).

This patch is not useful anymore anyway because there are remote-level
settings that *do* get stored on disk and can be used instead of
user-level settings when necessary.

Fixes #3061, and possibly #6153.
  • Loading branch information
code-asher committed Nov 20, 2023
1 parent 958c520 commit 54d758b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 67 deletions.
66 changes: 0 additions & 66 deletions patches/local-storage.diff

This file was deleted.

1 change: 0 additions & 1 deletion patches/series
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ logout.diff
store-socket.diff
proxy-uri.diff
unique-db.diff
local-storage.diff
service-worker.diff
sourcemaps.diff
disable-downloads.diff
Expand Down

1 comment on commit 54d758b

@bilogic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-asher is there a nightly build with this that I can test? Thanks!

Please sign in to comment.