Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update and pinned prettier to version 3.4.2 and fix ci #7111

Merged
merged 4 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Prettier 3.4.2
9b0340a09276f93c054d705d1b9a5f24cc5dbc97
16 changes: 12 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,25 @@ concurrency:

jobs:
prettier:
name: Format with Prettier
name: Run prettier check
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
- name: Checkout repo
uses: actions/checkout@v4

- name: Run prettier with actionsx/prettier
uses: actionsx/prettier@v3
- name: Install Node.js
uses: actions/setup-node@v4
with:
args: --check --log-level=warn .
node-version-file: .node-version
cache: npm
cache-dependency-path: |
package-lock.json
test/package-lock.json

- run: SKIP_SUBMODULE_DEPS=1 npm ci

- run: npx prettier --check .

doctoc:
name: Doctoc markdown files
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-prettier": "^5.0.0",
"globals": "^15.10.0",
"prettier": "^3.0.3",
"prettier": "3.4.2",
"prettier-plugin-sh": "^0.14.0",
"ts-node": "^10.9.1",
"typescript": "^5.6.2",
Expand Down
24 changes: 12 additions & 12 deletions src/node/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,18 @@ interface Option<T> {
type OptionType<T> = T extends boolean
? "boolean"
: T extends OptionalString
? typeof OptionalString
: T extends LogLevel
? typeof LogLevel
: T extends AuthType
? typeof AuthType
: T extends number
? "number"
: T extends string
? "string"
: T extends string[]
? "string[]"
: "unknown"
? typeof OptionalString
: T extends LogLevel
? typeof LogLevel
: T extends AuthType
? typeof AuthType
: T extends number
? "number"
: T extends string
? "string"
: T extends string[]
? "string[]"
: "unknown"

export type Options<T> = {
[P in keyof T]: Option<OptionType<T[P]>>
Expand Down
Loading