feat: implement Speaker and Serdes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds protobuf code generation - Adds utilities and wrapping code around RPC message types - Adds RPC protocol code required for sending and receiving messages - Adds a end-to-end test with messages and replies between two Speakers
The RpcMessage<T> type is now implemented directly on the protobuf types using partial classes.
ethanndickson
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
I'm happy with the repo structure, the namespaces, and I of course agree that the C# code should be idiomatic C# and not just a translation of the Go code. FWICT the C# API looks good.
LGTM, aside from the earlier RPC.MsgID thread - can probably just merge this for now?
Rpc/Utilities/TaskUtilities.cs
Outdated
| /// A task that completes when all tasks are completed, with the cancellation or exception state of the first | ||
| /// non-successful task | ||
| /// </returns> | ||
| public static async Task CancellableWhenAll(CancellationTokenSource cts, params Task[] tasks) |
spikecurtis
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
TODO:
csharp_namespaceoption to the upstreamvpn.protoCancellationTokenSourceinto more operations (any asyncSpeakeroperation should use the suppliedCancellationTokenas well as the globalCancellationTokenSource)TS/TSiandTR/TRiinto justTSandTRwith some finangling and changes around theRpcMessage<T>typeSpeakerat all