coder 2.1.4 #96
Merged
coder 2.1.4 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aslilac
commented
Aug 29, 2023
•
aslilac
commented
- Rename old formulae to all point at "coder@1" (since they've been identical for a long time anyway)
- Refactor coder@1 formula to simplify version updating
- Introduce new coder formula for installing full v2 binaries
- Add a script for updating the coder formula
- Setup tests to use the "official" brew testing pattern
- Includes all the nice things you'd expect like code formatting, hash validation, running brew tests, etc.
deansheather
approved these changes
Aug 29, 2023
Comment on lines
+15
to
+16
| url "https://github.com/coder/coder/releases/download/v#{version}/coder_#{version}_linux_amd64.tar.gz" | ||
| sha256 "41666bbe3afacd153fbe6c1a2d908bb4fb7a88e821205cb7136a0bad2d1cd6dc" |
There was a problem hiding this comment.
We have armv7, arm64 and amd64 for Linux so it'd be nice to do the Hardware::CPU checks for those too.
There was a problem hiding this comment.
Homebrew only supports x64 linux, unfortunately. It won't install or run on anything else. :\ If they ever add that platform support tho, we should 100% match it.
Correct. The way Homebrew handles this internally is actually super clever. :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.