[WIP] Use wildcard SSH config Host entries #521
Draft
+124
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @code-asher |
aaronlehmann
commented
Jan 10, 2025
| @@ -489,40 +510,53 @@ class CoderCLIManager( | |||
| Features( | |||
| disableAutostart = version >= SemVer(2, 5, 0), | |||
| reportWorkspaceUsage = version >= SemVer(2, 13, 0), | |||
| wildcardSSH = version >= SemVer(2, 18, 2), // FIXME use actual version that has https://github.com/coder/coder/pull/16088 | |||
There was a problem hiding this comment.
This needs to be filled in before merging.
aaronlehmann
changed the title
|
Looks good so far 😎 |
This simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. This can remove minutes from the "Configuring Coder CLI..." step when the user has access to many workspaces (for example, an admin who wants the option of connecting to anyone's workspace on a large deployment). Depends on coder/coder#16088
aaronlehmann
force-pushed
the
wildcard-ssh
branch
from
d8bbd31 to
ebf86fa
Compare
|
I think this is ready for review. The Coder CLI version number placeholder just needs to be filled in when that release happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. This can remove minutes from the "Configuring Coder CLI..." step when the user has access to many workspaces (for example, an admin who wants the option of connecting to anyone's workspace on a large deployment).
Depends on coder/coder#16088