Fix directory contents cache in imagefs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
force-pushed
the
mafredri/multistage-cache-probing-fix
branch
from
2800ccc
to
5e82e37
Compare
johnstcn
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25 we introduced
imagefs, however, it did not take into account folders being part offilesToCache, and thus, failed to cache all of the contents.In this PR we also remove "extraction progress" from imagefs. While it could be useful when analyzing really big archives, the messaging is confusing as we're not actually extracting the whole image onto disk.
A driveby os => filesystem.FS fix is here as well.