Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Amazon DCV Windows module #345

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

matifali
Copy link
Member

@matifali matifali commented Nov 20, 2024

Adds Amazon DCV for Windows workspaces.

Closes #344 along with coder/coder#15610

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 suggestion.

Files not reviewed (2)
  • amazon-dcv-windows/install-dcv.ps1: Language not supported
  • amazon-dcv-windows/main.tf: Language not supported

amazon-dcv-windows/README.md Show resolved Hide resolved
@matifali matifali requested a review from bpmct November 20, 2024 17:37
@matifali matifali force-pushed the atif/windows-dcv branch 2 times, most recently from 8b1bd8d to 016481d Compare November 20, 2024 18:00
- Introduce Amazon DCV for remote desktop on Windows workspaces.
- Script to install and configure DCV components.
- Terraform setup for configuring resources like coder_app.
- Ensure secure management with sensitive variable handling.

chore: add health check badge (#341)

chore: integrate Instatus in check script (#342)
Comment on lines +11 to +13
# Amazon DCV Windows

Amazon DCV is high performance remote display protocol that provides a secure way to deliver remote desktop and application streaming from any cloud or data center to any device, over varying network conditions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a nice screenshot or GIF for marketing purposes?

Copy link
Member Author

@matifali matifali Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add it, added now.

tags: [windows, dcv, web, desktop]
---

# Amazon DCV Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non AWS workspaces, does this work OK?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I tested it on GCP, and it works. You will see a notification about getting the license, though.

- Include visualization in README with new image
- Change icon path in Terraform configuration for DCV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon DCV Windows Integration
2 participants