-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Amazon DCV Windows module #345
base: main
Are you sure you want to change the base?
Conversation
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 suggestion.
Files not reviewed (2)
- amazon-dcv-windows/install-dcv.ps1: Language not supported
- amazon-dcv-windows/main.tf: Language not supported
8b1bd8d
to
016481d
Compare
- Introduce Amazon DCV for remote desktop on Windows workspaces. - Script to install and configure DCV components. - Terraform setup for configuring resources like coder_app. - Ensure secure management with sensitive variable handling. chore: add health check badge (#341) chore: integrate Instatus in check script (#342)
486efd5
to
e2c4a2c
Compare
e2c4a2c
to
ef1b086
Compare
# Amazon DCV Windows | ||
|
||
Amazon DCV is high performance remote display protocol that provides a secure way to deliver remote desktop and application streaming from any cloud or data center to any device, over varying network conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a nice screenshot or GIF for marketing purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add it, added now.
tags: [windows, dcv, web, desktop] | ||
--- | ||
|
||
# Amazon DCV Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For non AWS workspaces, does this work OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I tested it on GCP, and it works. You will see a notification about getting the license, though.
- Include visualization in README with new image - Change icon path in Terraform configuration for DCV
ef1b086
to
1c42546
Compare
Adds Amazon DCV for Windows workspaces.
Closes #344 along with coder/coder#15610