feat: add Amazon DCV Windows module #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
force-pushed
the
atif/windows-dcv
branch
2 times, most recently
from
8b1bd8d
to
016481d
Compare
- Introduce Amazon DCV for remote desktop on Windows workspaces. - Script to install and configure DCV components. - Terraform setup for configuring resources like coder_app. - Ensure secure management with sensitive variable handling. chore: add health check badge (#341) chore: integrate Instatus in check script (#342)
matifali
force-pushed
the
atif/windows-dcv
branch
2 times, most recently
from
486efd5
to
e2c4a2c
Compare
matifali
force-pushed
the
atif/windows-dcv
branch
from
e2c4a2c
to
ef1b086
Compare
bpmct
reviewed
Nov 20, 2024
Comment on lines
+11
to
+13
| # Amazon DCV Windows | ||
|
|
||
| Amazon DCV is high performance remote display protocol that provides a secure way to deliver remote desktop and application streaming from any cloud or data center to any device, over varying network conditions. |
There was a problem hiding this comment.
Can we add a nice screenshot or GIF for marketing purposes?
There was a problem hiding this comment.
Forgot to add it, added now.
bpmct
reviewed
Nov 20, 2024
| tags: [windows, dcv, web, desktop] | ||
| --- | ||
|
|
||
| # Amazon DCV Windows |
There was a problem hiding this comment.
For non AWS workspaces, does this work OK?
There was a problem hiding this comment.
Yes. I tested it on GCP, and it works. You will see a notification about getting the license, though.
bpmct
approved these changes
Nov 20, 2024
- Include visualization in README with new image - Change icon path in Terraform configuration for DCV
matifali
force-pushed
the
atif/windows-dcv
branch
from
ef1b086
to
1c42546
Compare
|
Are we good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Amazon DCV for Windows workspaces.
Closes #344 along with coder/coder#15610