Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kasm VNC #250

Merged
merged 48 commits into from
Oct 17, 2024
Merged

kasm VNC #250

merged 48 commits into from
Oct 17, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented May 17, 2024

closes #1

For testing,

module "kasmvnc" {
  source   = "git::https://github.com/coder/modules.git//kasmvnc?ref=kasmVNC"
  agent_id = coder_agent.dev.id
}

image

@matifali matifali self-assigned this May 17, 2024
@matifali matifali marked this pull request as ready for review May 17, 2024 16:09
@matifali
Copy link
Member Author

@johnstcn, should we publish an image codercom/enterprise-desktop with lxde pre-installed so that users can base their images on codercom/enterprise-desktop.
What do you think?

@matifali
Copy link
Member Author

kasmVNC has multi virtual monitor support

Screen.Recording.2024-05-17.at.10.56.05.PM.mov

matifali and others added 3 commits June 21, 2024 08:31
- Simplify and modularize the installation process
- Add mapping for different Linux distributions and architectures
- Validate the desktop environment to ensure compatibility
kasmvnc/main.tf Outdated Show resolved Hide resolved
@matifali matifali marked this pull request as ready for review September 30, 2024 06:51
@phorcys420
Copy link
Member

@matifali

Here's what happens when I install the KasmVNC module in my uwu/basic-env template.
I think it's due to the fact that Kasm thinks vncserver being installed means KasmVNC is.

Detected Distribution: ubuntu
Detected Version: 24.04
Detected Architecture: x86_64
vncserver is already installed.
vncserver already installed. Skipping installation.
bash: line 1: /etc/kasmvnc/kasmvnc.yaml: No such file or directory
🚀 Starting KasmVNC server...
Usage: vncpasswd [FILE]
       vncpasswd -t

I will retry with a template that doesn't have VNC but it looks good to me other than that.

@matifali
Copy link
Member Author

matifali commented Oct 2, 2024

Yes. The command that gets installed by kasmVNC is also vncserver.

Copy link
Member

@phorcys420 phorcys420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kasmvnc/README.md Show resolved Hide resolved
kasmvnc/run.sh Show resolved Hide resolved
@matifali matifali marked this pull request as draft October 4, 2024 13:24
By refining the package manager options, this change prevents the installation of unnecessary recommended and suggested packages, streamlining the process.
Simplify and unify the RPM installation process by using the
consistent temporary directory path for downloading RPM files.
This reduces potential errors and ensures uniform script behavior
between different OS installations.
@matifali matifali marked this pull request as ready for review October 5, 2024 18:13
Copy link

@jatcod3r jatcod3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Tested on your Coder deployment and didn't see any issues in logs, nor any connection issues on the Coder console.

@matifali
Copy link
Member Author

I still need to update the READEME to mention our desktop image. Then I will merge.

@matifali matifali enabled auto-merge (squash) October 17, 2024 02:02
@matifali matifali merged commit 48c81c9 into main Oct 17, 2024
2 checks passed
@matifali matifali deleted the kasmVNC branch October 17, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kasmVNC Module
6 participants