Do not require token auth with mTLS #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/optional-token
branch
2 times, most recently
from
698f7ff
to
cc2823b
Compare
code-asher
force-pushed
the
asher/optional-token
branch
from
cc2823b
to
763ea09
Compare
bcpeinhardt
reviewed
Oct 29, 2024
bcpeinhardt
reviewed
Oct 29, 2024
bcpeinhardt
reviewed
Oct 29, 2024
bcpeinhardt
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategy: when configuring the cli, write blank token files, since currently the
vscodesshcommand always expects a file. Still need to validate if this works; if not we may need to write something likeunusedor modify the cli itself.We configure in two places: login via command palette and dashboard link, so both those code paths are changed to write
""when not using token auth. Additionally, the login route is changed to not prompt for the token (failure to auth will be a hard error instead).