properly escape . in host -> ssh conversion #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Jan 17, 2025
bcpeinhardt
deleted the
bcpeinhardt/escape-dots-in-ssh-to-regex-conversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating that our settings are not overridden by a user's ssh config, we were converting host names to regular expressions to use as matchers. In doing so, we were not correctly escaping
.characters, which are special in regular expressions but not in host names.This triggered a false flag when using the vscode extension alerting the user they were improperly overriding settings which they were not.
Note: this didn't come up before because we only now started using
coder.has a host name in the ssh config as part of updating the vscode extension to simply usecoder sshas opposed to a dedicatedcoder vscodesshcommand.