Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase quotas in appstudio and appstudiolarge #1045

Merged

Conversation

hugares
Copy link
Contributor

@hugares hugares commented Jun 19, 2024

appstudio:

  • Parametrize request storage, keep same value of 200Gi
  • Set build CPU request to half of limit, i.e. 60.

appstudiolarge:

  • Set request storage to double of appstudio tier, i.e. 400Gi.
  • Set build CPU request to half of limit, i.e. 240.
  • Set build memory request to half of limit, i.e. 256Gi.

KFLUXINFRA-632

appstudio:
* Parametrize request storage, keep same value of 200Gi
* Set build CPU request to half of limit, i.e. 60.
appstudiolarge:
* Set request storage to double of appstudio tier, i.e. 400Gi.
* Set build CPU request to half of limit, i.e. 240.
* Set build memory request to half of limit, i.e. 256Gi.

KFLUXINFRA-632

Signed-off-by: Hugo Arès <[email protected]>
Copy link

openshift-ci bot commented Jun 19, 2024

Hi @hugares. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hugares added a commit to hugares/toolchain-e2e that referenced this pull request Jun 19, 2024
appstudio:
* Parametrize request storage, keep same value of 200Gi
* Set build CPU request to half of limit, i.e. 60.

appstudiolarge:
* Set request storage to double of appstudio tier, i.e. 400Gi.
* Set build CPU request to half of limit, i.e. 240.
* Set build memory request to half of limit, i.e. 256Gi.

Paired with codeready-toolchain/host-operator#1045

KFLUXINFRA-632

Signed-off-by: Hugo Arès <[email protected]>
@mfrancisc
Copy link
Contributor

/ok-to-test

@hugares
Copy link
Contributor Author

hugares commented Jun 20, 2024

@mfrancisc I do not understand why codecov check is failing, any idea what should I do?

@mfrancisc
Copy link
Contributor

mfrancisc commented Jun 20, 2024

It doesn't look related to your changes : https://app.codecov.io/gh/codeready-toolchain/host-operator/pull/1045/indirect-changes

Even because you are not changing any go code in this PR. Feel free to merge , once you have the required approvals.

@hugares
Copy link
Contributor Author

hugares commented Jun 20, 2024

@mfrancisc Can you approve and merge, I do not have any rights here?

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (d5fbf58) to head (4969a2b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage   84.83%   84.79%   -0.05%     
==========================================
  Files          55       55              
  Lines        4919     4919              
==========================================
- Hits         4173     4171       -2     
- Misses        572      574       +2     
  Partials      174      174              

see 2 files with indirect coverage changes

Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, hugares, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov alexeykazakov merged commit eaadfb5 into codeready-toolchain:master Jun 20, 2024
9 of 11 checks passed
alexeykazakov pushed a commit to codeready-toolchain/toolchain-e2e that referenced this pull request Jun 20, 2024
appstudio:
* Parametrize request storage, keep same value of 200Gi
* Set build CPU request to half of limit, i.e. 60.

appstudiolarge:
* Set request storage to double of appstudio tier, i.e. 400Gi.
* Set build CPU request to half of limit, i.e. 240.
* Set build memory request to half of limit, i.e. 256Gi.

Paired with codeready-toolchain/host-operator#1045

KFLUXINFRA-632

Signed-off-by: Hugo Arès <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants