skip PublicViewer's SBR deletion if PublicViewer is enabled #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Ilario <[email protected]>
|
Skipping CI for Draft Pull Request. |
filariow
changed the title
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
This commit adds the notion of Public-Viewer as described in https://issues.redhat.com/browse/ASC-532. Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
filariow
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
/retest |
1 similar comment
|
/retest |
mfrancisc
reviewed
Jul 3, 2024
controllers/spacebindingcleanup/spacebinding_cleanup_controller.go
Outdated
Show resolved
Hide resolved
controllers/spacebindingcleanup/spacebinding_cleanup_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/spacebindingcleanup/spacebinding_cleanup_controller_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Francesco Ilario <[email protected]>
|
/retest it seems a flakiness |
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
mfrancisc
approved these changes
Jul 4, 2024
controllers/spacebindingcleanup/spacebinding_cleanup_controller_test.go
Outdated
Show resolved
Hide resolved
controllers/spacebindingcleanup/spacebinding_cleanup_controller_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
fbm3307
reviewed
Jul 11, 2024
fbm3307
approved these changes
Jul 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, filariow, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Francesco Ilario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
+ Coverage 85.05% 85.10% +0.04%
==========================================
Files 55 55
Lines 5018 5028 +10
==========================================
+ Hits 4268 4279 +11
+ Misses 580 579 -1
Partials 170 170
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the controller changes for Public-Viewer support.
It supersedes #1021.
JIRA ASC-532