use FakeClient as backend for RESTClient based unit tests #469
Conversation
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
| func (s *ServiceFactory) WithSignupService(signupService service.SignupService) { | ||
| s.signupServiceFunc = func(_ ...signupservice.SignupServiceOption) service.SignupService { | ||
| return signupService | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a temp hack to inject specific fake version of signupService without any extra abstraction and additional mocking.
| type CrtClientProvider struct { | ||
| Cl kubeclient.CRTClient |
There was a problem hiding this comment.
Also a temp hack until this type is gonna be removed completely
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 81.83% 81.86% +0.03%
==========================================
Files 42 42
Lines 2708 2708
==========================================
+ Hits 2216 2217 +1
+ Misses 406 405 -1
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MatousJobanek
merged commit 6d3e720
into
codeready-toolchain:master
It's a follow-up of the previous PR doing changes in unit-tests. This time for the CRTClient use-cases.
The PR is a bit bigger, but there is no chance to make it smaller. I could separate the removal, but I wanted to highlight what has been removed/replaced by these changes.
The same as before, the PR is about dropping the old mocks of the CRTClient by replacing their usage with the FakeClient. It doesn't try to improve the coverage nor the tests themself.
In the modified tests, I also dropped the usage of the MockableApplication type. I'll do the same also in the other tests in the following PR(s). There is still so many things to be removed and optimized :-).
KUBESAW-193