-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow proxy to forward requests to namespaces outside of workspace #471
Merged
alexeykazakov
merged 13 commits into
codeready-toolchain:master
from
alexeykazakov:proxy-namespace
Oct 29, 2024
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d1cf75b
Allow proxy to forward requests to namespaces outside of workspace
alexeykazakov 6656eb2
linter
alexeykazakov 228625c
Merge branch 'master' into proxy-namespace
mfrancisc c8cc345
Merge branch 'master' into proxy-namespace
alexeykazakov db076ea
Merge branch 'master' into proxy-namespace
alexeykazakov 1fee789
Update pkg/proxy/proxy.go
alexeykazakov 30aae25
Merge branch 'master' into proxy-namespace
alexeykazakov 391224f
Update pkg/proxy/proxy_community_test.go
alexeykazakov d7f9901
Merge branch 'master' into proxy-namespace
alexeykazakov c557b41
Update pkg/proxy/proxy_community_test.go
alexeykazakov c6fd25a
Merge branch 'master' into proxy-namespace
alexeykazakov 56f55b6
Merge branch 'master' into proxy-namespace
alexeykazakov 1844bef
Merge branch 'master' into proxy-namespace
alexeykazakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused as to what does 'owner' refer to here in the test description. To me, there is not much difference in the two statements below, wrt to the test:
plain http request as owner to namespace outside of private workspace
v/splain http request to namespace outside of private workspace
.So either I'm missing the significance of
owner
here and we should add it here (maybe in the comments?) or we can make the test case description simpler and remove owner.Let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comments preceeding it explain it pretty well. But yeah the 'owner' thing in the test description threw me off a bit as well.
What about
plain http request as permitted user to namespace outside of private workspace
? Is that accurate?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced
owner
bypermitted user
in c557b41