Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make go linter 1.60.3 happy #485

Conversation

MatousJobanek
Copy link
Contributor

update the linter to 1.60.3 and address all complaints
it's mainly related to the way the sub-tests are executed inside the suites. Ideally, we would like to get rid of the suites, but let's keep it there for now and make the code consistent

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
31.2% Duplication on New Code (required ≤ 30%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (9c50de7) to head (0b2fefa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files          32       32           
  Lines        3172     3172           
=======================================
  Hits         2711     2711           
  Misses        374      374           
  Partials       87       87           
Flag Coverage Δ
unittests 85.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov
Copy link
Contributor

/retest

1 similar comment
@MatousJobanek
Copy link
Contributor Author

/retest

@MatousJobanek MatousJobanek merged commit 258c17c into codeready-toolchain:master Nov 19, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants