Update JWT dependency #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykazakov
requested review from
MatousJobanek,
xcoulon,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 76.42% 76.42%
=======================================
Files 43 43
Lines 1998 1998
=======================================
Hits 1527 1527
Misses 424 424
Partials 47 47 |
ranakan19
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Looks good. Go-lint has pointed out some things to be fixed. Maybe NewNumericDate function should be used to set NumericDate values.
mfrancisc
approved these changes
Jan 14, 2024
Signed-off-by: Xavier Coulon <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for codeready-toolchain/registration-service#391