Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move EncodeUserIdentifier & signup helper functions #452

Merged

Conversation

MatousJobanek
Copy link
Contributor

move EncodeUserIdentifier function here and add a few UserSignup helper function. The most important one is the WithEncodedName one - to have an easy way of using the encoded value as the name of the UserSignup and the original value as the preffered username.

KUBESAW-254

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (8e02342) to head (609c649).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   78.23%   78.47%   +0.23%     
==========================================
  Files          49       49              
  Lines        2444     2471      +27     
==========================================
+ Hits         1912     1939      +27     
  Misses        478      478              
  Partials       54       54              
Files with missing lines Coverage Δ
pkg/usersignup/usersignup.go 100.00% <100.00%> (ø)

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Collaborator

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MatousJobanek MatousJobanek merged commit 8ef21eb into codeready-toolchain:master Jan 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants