feat: Implement public API that will open SpaceBindings to end users through proxy part 1

[mfrancisc]

Update proxy (spacelister) e2e tests to check for the newly added workspace.Status.AvailableRoles field. The field should contain the Space roles for the NSTemplateTier.
For example in the case of appstudio tier the list should be: admin, maintainer, contributor

Jira story: https://issues.redhat.com/browse/ASC-410

Related PRs:

• feat: Implement public API that will open SpaceBindings to end users through proxy part 1 toolchain-common#327

Paired with:

• feat: Implement public API that will open SpaceBindings to end users through proxy part 1 registration-service#348

[alexeykazakov]

I guess the /workspace/:name case will be covered in the following PR(s)?

[mfrancisc]

I guess the /workspace/:name case will be covered in the following PR(s)?

@alexeykazakov TBH I thought that updating the TestSpaceLister test and specifically the test cases that are getting a specific (work)space would be enough to cover my changes. But please let me know if I'm missing some tests.

[alexeykazakov]

TBH I thought that updating the TestSpaceLister test and specifically the test cases that are getting a specific (work)space would be enough to cover my changes. But please let me know if I'm missing some tests.

I didn't notice that we already have a test for /workspace/:name. I thought it's only for the list: /workspace. So, you are right. TBH I thought we do not currently support /workspace/:name at all. This is why I wanted to introduce a new handler (and a route) for that instead of modifying the existing handler.

[mfrancisc]

/retest

reg-service PR was updated

[MatousJobanek]

Nice 👍

[MatousJobanek]

it's just a detail, but since you introduced the options, then you could update the function to:

func expectedWorkspaceFor(t *testing.T, hostAwait *wait.HostAwaitility, user *proxyUser, additionalWSOptions ...commonproxy.WorkspaceOption) toolchainv1alpha1.Workspace {

and then call it:

Suggested change

	verifyHasExpectedWorkspace(t, expectedWorkspaceFor(t, awaitilities.Host(), users["bicycle"], true, appStudioTierRolesWSOption), *bicycleWS)
	verifyHasExpectedWorkspace(t, expectedWorkspaceFor(t, awaitilities.Host(), users["bicycle"], commonproxy.WithType("home"), appStudioTierRolesWSOption), *bicycleWS)

[mfrancisc]

Good point! Thanks!

I've replaced the parameter with the option. Please see: 2fb797d

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication