Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial stab at adding vanity domain modal logic #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial stab at adding vanity domain modal logic #99

wants to merge 1 commit into from

Conversation

afahy
Copy link
Collaborator

@afahy afahy commented May 4, 2020

Not ready for merge, but wanted to push this in-progress branch for local testing.

@afahy afahy requested a review from jorge-caballero May 4, 2020 02:23
jorge-caballero
jorge-caballero reviewed May 4, 2020
View reviewed changes
Copy link
Member

@jorge-caballero jorge-caballero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modal looks very, very nice. Selecting an item doesn't do anything, but I believe that is to be expected at this point. If i'm wrong, then let me know how I can help TS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorge-caballero jorge-caballero jorge-caballero left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afahy @jorge-caballero