Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ubb waitlist banner #8213

Merged
merged 6 commits into from
Dec 1, 2023
Merged

feat: ubb waitlist banner #8213

merged 6 commits into from
Dec 1, 2023

Conversation

alexnm
Copy link
Contributor

@alexnm alexnm commented Dec 1, 2023

A few small UI differences compared to the figma design:

  • Pay only for what you use in Everett, not in Inter
  • no border radius to match the subscription cards

image

Add target="_blank" and rel="noreferrer noopener" attributes
Updated labels for editors, repositories, and sandboxes
@alexnm alexnm requested review from danilowoz and necoline December 1, 2023 08:38
Copy link

codesandbox bot commented Dec 1, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@ed-codesandbox
Copy link
Contributor

I also had mixed thoughts about the border radius. It doesn't conform to the style of pricing boxes, but at the same time signals that this is something that's outside the "normal" version of the page. If you think square corners work better, let's go with those.

Everett also works - if we use it, it should be medium weight though. Is this medium weight? It seems narrower but that might just be because it's dark on light / rendered in the browser.

Upgrade.tsx: remove isPaddle from useWorkspaceSubscription function
@alexnm alexnm enabled auto-merge (squash) December 1, 2023 10:17
@alexnm alexnm merged commit 2ad149d into master Dec 1, 2023
@alexnm alexnm deleted the draft/suspicious-hopper branch December 1, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants