fix: edit the file reading logic

codescalersinternships · Sep 9, 2024 · 02db807 · 02db807
1 parent c9d6041
commit 02db807
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/cmd/head/main.go b/cmd/head/main.go
@@ -5,7 +5,6 @@ import (
 	"flag"
 	"log"
 	"os"
-	"strings"
 
 	internal "github.com/codescalersinternships/Coreutils-Rawan-Mostafa/internal"
 )
@@ -19,12 +18,14 @@ func main() {
 	if len(flag.Args()) == 0 {
 		log.Fatal("No file argument passed to the command")
 	}
-	data, err := os.ReadFile(flag.Args()[0])
+
+	filePath := flag.Args()[0]
+	file, err := os.Open(filePath)
 	if err != nil {
-		log.Fatal("Error in reading the file")
+		log.Fatal("Error in opening the file")
 	}
-
-	scanner := bufio.NewScanner(strings.NewReader(string(data)))
+	defer file.Close()
+	scanner := bufio.NewScanner(file)
 
 	err = internal.Head(scanner, n)
 	if err != nil {

diff --git a/cmd/tail/main.go b/cmd/tail/main.go
@@ -5,7 +5,6 @@ import (
 	"flag"
 	"log"
 	"os"
-	"strings"
 
 	internal "github.com/codescalersinternships/Coreutils-Rawan-Mostafa/internal"
 )
@@ -19,12 +18,14 @@ func main() {
 	if len(flag.Args()) == 0 {
 		log.Fatal("No file argument passed to the command")
 	}
-	data, err := os.ReadFile(flag.Args()[0])
+
+	filePath := flag.Args()[0]
+	file, err := os.Open(filePath)
 	if err != nil {
-		log.Fatal("Error in reading the file")
+		log.Fatal("Error in opening the file")
 	}
-
-	scanner := bufio.NewScanner(strings.NewReader(string(data)))
+	defer file.Close()
+	scanner := bufio.NewScanner(file)
 
 	err = internal.Tail(scanner, n)
 	if err != nil {