This repository has been archived by the owner on Jun 4, 2019. It is now read-only.
Adds 'skip_read' flag for comments only containing :nodoc: #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,7 @@ def unassigned_read_doc_methods(limit = self.read_limit) | |||
| repo.methods_with_docs. | |||
| active. | |||
| where("doc_methods.id not in (?)", pre_assigned_doc_method_ids). | |||
| where(skip_read: false) | |||
There was a problem hiding this comment.
You're missing a fullstop . here so the method chaining is no longer working (it's not calling order after your where anymore)
There was a problem hiding this comment.
ah, good catch. Thank you!!
* skip_read flag set by comments that eql ':nodoc:' * prevents emails from being sent that encourage subscriber to read docs which are essentiall blank * side effect that these docs won't be sent out for write either
|
CI passes now - @schneems what do you think? My initial thought is that this column should be indexed. |
|
Looks good, thanks! |
schneems
added a commit
that referenced
this pull request
Dec 3, 2014
Adds 'skip_read' flag for comments only containing :nodoc:
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs which are essentiall blank
addresses issue #9