Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Add commit sha to repo #40

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Add commit sha to repo #40

merged 1 commit into from
Nov 23, 2015

Conversation

kddnewton
Copy link
Contributor

Store the commit sha of the time the repo was last processed. Ensures the emails point to the correct location in source. Fixes issue #39.

Store the commit sha of the time the repo was last processed. Ensures
the emails point to the correct location in source.
@schneems
Copy link
Member

thanks!

schneems added a commit that referenced this pull request Nov 23, 2015
@schneems schneems merged commit ee46f12 into codetriage:master Nov 23, 2015
@kddnewton
Copy link
Contributor Author

Just need to make sure to run the process! before the next release so commit_sha gets populated. @schneems

@schneems
Copy link
Member

Just got a link to https://github.com/rails/rails/blob/a7379ce9efb01fb3cd6d9cf6b09b698995377d5a/actionpack/lib/action_dispatch/http/response.rb/#L310 but it is supposed to be ActionDispatch::Response#merge_default_headers but instead it is

Any ideas?

@kddnewton
Copy link
Contributor Author

@schneems Yeah some of the links that I'm getting are right and some of them are off. Any chance that between the time the git clone is executed and the sha is saved there's a delay? Rails gets stuff merged pretty quickly.

Also, interestingly, all of my ruby repo links are correct, but the rails ones are not.

@kddnewton
Copy link
Contributor Author

@schneems After some further investigation, that file hasn't been updated in a while, so my initial theory can't be right. I'll do some more investigation after work today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants