Feature/cd pipeline #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce will be hosted on google cloud run
…le for europe-west10
Laurin-Notemann
force-pushed
the
feature/cd-pipeline
branch
from
0ec7c6b to
7b8f3ec
Compare
alkaline-0
reviewed
May 23, 2024
There was a problem hiding this comment.
Why delete the commands? what if you want to test building the docker image locally?
There was a problem hiding this comment.
By removing github single sign on action, we will not be able to use the template "add-existing-elements" this is fine but I wanted to flag it anyway
There was a problem hiding this comment.
I understand you wanted to clean up the clutter, my question is, can't we use the k8s plugin for the students' deployment?
alkaline-0
approved these changes
May 23, 2024
AGiljanovic
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CD pipeline on google run, only thing thats missing is the visibility of the templates and the catalog in general, but everything else is working. https://backstage.foundations-software-engineering.com