logic improved

codex-team · Oct 14, 2024 · 63e403f · 63e403f
1 parent acb1383
commit 63e403f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/components/ui/toolbox.ts b/src/components/ui/toolbox.ts
@@ -308,23 +308,23 @@ export default class Toolbox extends EventsDispatcher<ToolboxEventMap> {
     /**
      * Maps tool data to popover item structure
      */
-    const toPopoverItem = (toolboxItem: ToolboxConfigEntry, tool: BlockToolAdapter, index?: number): PopoverItemParams => {
+    const toPopoverItem = (toolboxItem: ToolboxConfigEntry, tool: BlockToolAdapter, displaySecondaryLabel?: boolean): PopoverItemParams => {
       return {
         icon: toolboxItem.icon,
         title: I18n.t(I18nInternalNS.toolNames, toolboxItem.title || _.capitalize(tool.name)),
         name: tool.name,
         onActivate: (): void => {
           this.toolButtonActivated(tool.name, toolboxItem.data);
         },
-        secondaryLabel: (tool.shortcut && index === 0) ? _.beautifyShortcut(tool.shortcut) : '',
+        secondaryLabel: (tool.shortcut && displaySecondaryLabel) ? _.beautifyShortcut(tool.shortcut) : '',
       };
     };
 
     return this.toolsToBeDisplayed
       .reduce<PopoverItemParams[]>((result, tool) => {
         if (Array.isArray(tool.toolbox)) {
           tool.toolbox.forEach((item, index) => {
-            result.push(toPopoverItem(item, tool, index));
+            result.push(toPopoverItem(item, tool, index === 0));
           });
         } else if (tool.toolbox !== undefined)  {
           result.push(toPopoverItem(tool.toolbox, tool));

diff --git a/test/cypress/tests/ui/toolbox.cy.ts b/test/cypress/tests/ui/toolbox.cy.ts
@@ -152,10 +152,10 @@ describe('Toolbox', function () {
         .type('Some text')
         .type('/'); // call a shortcut for toolbox
 
-
       /**
        * Secondary title (shortcut) should exist for first toolbox item of the tool
        */
+      /* eslint-disable-next-line cypress/require-data-selectors */
       cy.get('.ce-popover')
         .find('.ce-popover-item[data-item-name="severalToolboxItemsTool"]')
         .first()
@@ -165,6 +165,7 @@ describe('Toolbox', function () {
       /**
        * Secondary title (shortcut) should not exist for second toolbox item of the same tool
        */
+      /* eslint-disable-next-line cypress/require-data-selectors */
       cy.get('.ce-popover')
         .find('.ce-popover-item[data-item-name="severalToolboxItemsTool"]')
         .eq(1)