Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Russian landing #58

Merged
merged 27 commits into from
Jul 13, 2024
Merged

feat(ui): Russian landing #58

merged 27 commits into from
Jul 13, 2024

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Jul 8, 2024

Now Hawk landing has /ru route with russian information about the project
Also there is contact component, which sends notifications to tg chat on button click

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the footer on original landing
image


.team-hawk-so-t-me {
display: inline;
font-family: "Roboto-Regular", Helvetica;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work since font with this name is not connected. But Roboto is already connected at the layouts/ru.vue to the HTML tag so you don't need to override it.

Comment on lines 144 to 146
@media (--screen-middle) {
line-height: 30px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin between title and description is missed
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headings line-height are too big

image

Comment on lines +123 to +131
.title {
font-size: 24px;
line-height: 28.13px;
font-weight: 700;
color: #DBE6FF;
text-align: center;
}

.text {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectors are not enough specific, it can lead conflicts. use <style scoped> or use BEM

});
</script>

<style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use scoped style as well

Comment on lines 8 to 9
или в телеграм
<a href="https://t.me/+xWe73YEfIVRlNmYy">t.me/hawk-support</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected linebreak
image

@@ -0,0 +1,199 @@
<template>
<div class="box">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong color for bottom contacts form.

On the top contact form color should be — #F2F6FF
On the bottom contact form color should be — #DBE6FF

image

Comment on lines 56 to 57
<div class="title">Поддерживает<br/>ваши технологии</div>
<div class="text">Хоук имеет интеграции с популярными<br/>технологиями и фреймворками. </div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin between title and description is too big

image

<div class="block">
<div class="grid__block">
<div class="title">Open Source</div>
<div class="text">Исходный код открыт для исследования и обслуживания</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should has 2 lines

Now

image

Should be

image

Comment on lines +27 to +30
href="/download">
<img src="~/assets/svg/locale-version.svg" class="site-header__menu__local-version-svg"/>
<div class="text-container">Локализованная версия</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove the Localized version label from mobile menu
image

@e11sy e11sy merged commit 8e84832 into master Jul 13, 2024
1 check passed
@e11sy e11sy deleted the russian-landing branch July 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants