Chore[ Tests ]: upgrade to tests with testcontainers #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added redis helper class and some methods for digest and threshold storing - added env.sample for redis connections - added dependencies related to redis
- add notifier method to get threshold from redis or from db - add notifier method to check if event is critical - updated lock
- get rid of the buffer - move types to types directory - improve old comments
- updated redis lib to 4.7.0 in root of workers - updated limiter redisHelper to the new redis request format - updated tests for limiter worker
neSpecc
approved these changes
Dec 25, 2024
Co-authored-by: Peter <[email protected]>
e11sy
changed the base branch from
notifier-refactoring
to
setup-redis-testcontainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #326 we decided to set up redis
testcontainerfor tests instead ofredis-mocklibAlso we needed to use new version of
redispackage (from3.1.1->4.7.0)Note that testcontainer is set up in #326
Problem
redis-mockwe need to rewrite tests to new patternredisClientcallsredesClientcalls in testsSolution
LimiterandGrouperworkers for them to be compatible with newredisversioninitialize()andclose()methods for RedisHelpers (now they are initialized and closed same as db inworker.start()andworker.finish())"redis": "^4.7.0"is root worker dependencie (since same version is used for tests)