-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recent-notes): save and delete note visits on the appropriate routes #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added method for deletion of all note visits for certain note - added saving of note visits on post note and get note endpoints
- bad fix of the problem with camelcase to snake translation (in conflict where)
Coverage Report
File Coverage
|
e11sy
changed the title
Recent note list
feat(recent-notes): save note visits on get/post note
Apr 5, 2024
e11sy
changed the title
feat(recent-notes): save note visits on get/post note
feat(recent-notes): save and delete note visits on the appropriate routes
Apr 5, 2024
TatianaFomina
approved these changes
Apr 5, 2024
elizachi
reviewed
Apr 5, 2024
elizachi
approved these changes
Apr 5, 2024
neSpecc
reviewed
Apr 5, 2024
- get rid of noteVisits service to avoid circular dependency via shared service - moved noteVisitsService methods to noteService
neSpecc
requested changes
Apr 6, 2024
As i remember, you faced with a trouble, that you need to create a unique index ( |
slaveeks
approved these changes
Apr 6, 2024
- left todo about event bus usage for saving and deleting noteVIsits
neSpecc
approved these changes
Apr 7, 2024
Co-authored-by: Tatiana Fomina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
visitedAt
field with stringExtra
NOW()
function toCURRENT_TIMESTAMP()
because it represents full timestamp (date with time) andNOW()
returns only date