Relocated "fill*" methods #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
reviewed
Mar 20, 2020
|
Tests should be modified(the functions are shifted, so appropriate updates should be made there as well). The instantiated template files are also required to be updated. You can run tests locally using, |
Co-Authored-By: Gagandeep Singh <[email protected]>
Making this fork up to date
updating this branch
czgdp1807
reviewed
Apr 3, 2020
czgdp1807
reviewed
Apr 3, 2020
| @@ -19,9 +18,15 @@ We are using the following technologies in our project, | |||
| 4. Google Test | |||
| 5. Boost.Python | |||
|
|
|||
|
|
|||
czgdp1807
reviewed
Apr 3, 2020
README.md
Outdated
Comment on lines
111
to
112
| ======= | ||
|
|
czgdp1807
reviewed
Apr 3, 2020
czgdp1807
changed the title
Co-Authored-By: Gagandeep Singh <[email protected]>
Co-Authored-By: Gagandeep Singh <[email protected]>
|
Closing in favour of #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10
Removed
fillmethod from the matrix and vector classes present indata structures.hpp,data_structures_impl.cpp,cuda_data_structures.hppandcuda_data_structures_impl.hppmoved them tooperations.hppandoperations_impl.cpp.Also removed multiply, product functions from
data structures.hppanddata_structures_impl.cppand moved them to operations.hpp and operations_impl.cpp.Added comments to the re-located functions.