add build lua #133
add build lua #133
Conversation
|
I think we shouldn't call it on every initialization (because this makes network requests), but maybe if there's no binaries installed, then run it? |
|
Yes, that's what I meant :).. this is how it works with other plugins |
|
@amirbilu Having tried to implement this for a while, there doesn't seem to be an easy way without up-ending the rest of the codebase. In order to build asynchronously (and not block the entire editor), I would have to change every invocation to TabnineBinary:start and :request to be callback-based. I can do this if you'd like, but it would be a much larger PR and likely would be a (set of) breaking change(s). I can build it synchronously if you'd like, but this would freeze the entire editor window. |
|
Got you. What are you suggesting? What option is better in your opinion |
Well, ideally, we’d go to a callback-based system, but I would rather not implement those changes, so perhaps we run it synchronously and just deal with the freeze? It should only happen once anyways, right? |
|
Freezing the IDE sounds scary to me.. but I would not want to give up on this. Maybe I could find time to refactor this to async |
This is supported by lazy.nvim to automagically build the project.
…azy no longer requires user intervention
We don't care about stdout since it's just progress indicators. These are too noisy to notify on.
`/build.lua` is now just a light wrapper for tabnine.build -- to continue lazy.nvim support
This will only run once, and it checks to ensure the machine is supported before wasting resources/time. If it fails, we warn and direct the user to create an issue if they can't run the script manually.
This is currently unused
This plays nicer with nvim-notify (A very common vim.notify replacement plugin), by showing only one message at a time, instead of stacking them. When using stock nvim, this should make no difference.
This is now okay, due to the previous commit (a25ecf3), so these messages will now not stack when using vim-notify. these show only one message at a time. For another example of a plugin which shows progress messages like this, see nvim-treesitter/nvim-treesitter.
aarondill
force-pushed
the
add-build-lua
branch
from
f438871
to
f910a3b
Compare
|
I've rebased this to the current state of master (eb914c2) |
|
@amirbilu Ive rethought this pr, and I think i can make it work asynchronously (I'm going to copy from nvim-treesitter's async install). should I also add a |
feat: add a build.lua file
This is supported by lazy.nvim to automagically build the project.