-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV2-4433 chat api usage #1397
DEV2-4433 chat api usage #1397
Conversation
src/tabnineChatWidget/ChatApi.ts
Outdated
isTelemetryEnabled: boolean; | ||
}; | ||
|
||
export class ChatApi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
].includes(vscode.window.activeColorTheme.kind), | ||
isTelemetryEnabled: isCapabilityEnabled(Capability.ALPHA_CAPABILITY), | ||
serverUrl, | ||
isSelfHosted: context.workspaceState.get( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yonip23 this was changed to be injected from the ctor, and not managed as a flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meant @yonip23 and not @yonidavidson 🤦♂️
@@ -111,15 +102,8 @@ export default class ChatViewProvider implements WebviewViewProvider { | |||
}); | |||
} | |||
|
|||
waitForChatInitiated(): Promise<void> { | |||
return new Promise((resolve) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yairco1990 - this was changed to be promise based here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice change 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DEV2-4433 chat api usage
highlights:
the chat api is now a class that exposes
this class is inited differently from the saas extension and the enterprise extension