Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: json -> data (for future compat) #241

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Nov 13, 2024

drops the last usage of deprecated json and replaces it with a call to data (needed for the headers option)

we need to ensure Codux supports the data hook before merging this.

@AviVahl AviVahl marked this pull request as draft November 13, 2024 12:47
@@ -3,6 +3,12 @@ import { defineConfig } from 'vite';
import tsconfigPaths from 'vite-tsconfig-paths';
import { netlifyPlugin } from '@netlify/remix-adapter/plugin';

declare module '@remix-run/node' {
interface Future {
v3_singleFetch: true;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this augments the type and ensures useLoaderData can infer the correct type.
it is the default in current create-remix generated apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant