Skip to content

Commit

Permalink
Make MultiFragmentTest.partitionedOutputWithLargeInput run faster (fa…
Browse files Browse the repository at this point in the history
…cebookincubator#8610)

Summary:
Pull Request resolved: facebookincubator#8610

MultiFragmentTest.partitionedOutputWithLargeInput sometimes runs for a very long time, more than 10 minutes.

Fortunately the test is documented with a comment, and it looks like we can get the same coverage on a smaller input
dataset, which reduces the test time proportionatly.

Reviewed By: pedroerp

Differential Revision: D53242660

fbshipit-source-id: 8b17f731bceebcc886847244746a6b93629b21d8
  • Loading branch information
Kevin Wilfong authored and facebook-github-bot committed Feb 1, 2024
1 parent 0579f97 commit 790d6bd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions velox/exec/tests/MultiFragmentTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,8 @@ TEST_F(MultiFragmentTest, partitionedOutputWithLargeInput) {
// We create a large vector that hits the row limit (70% - 120% of 10,000)
// which would hit a task level memory limit of 1MB unless its split up.
// This test exercises splitting up the input both from the edges and the
// middle as it ends up splitting it in ~ 10 splits.
setupSources(1, 100'000);
// middle as it ends up splitting it in ~ 3 splits.
setupSources(1, 30'000);
const int64_t kRootMemoryLimit = 1 << 20; // 1MB
// Single Partition
{
Expand Down

0 comments on commit 790d6bd

Please sign in to comment.