Cleanup window function registry tests (facebookincubator#8057)

Summary:
There are two test files for validating window function registration:
1. velox/functions/prestosql/window/tests/WindowFunctionRegTest.cpp
2. velox/exec/tests/WindowFunctionRegistryTest.cpp

This PR moves the tests from 1 into 2, and removes 1. This follows from the
conversation in facebookincubator#7243.

Pull Request resolved: facebookincubator#8057

Reviewed By: kgpai

Differential Revision: D52208891

Pulled By: kagamiori

fbshipit-source-id: 0ce444faa24247cd8d69d12b969b90adce873511

velox/exec/tests/CMakeLists.txt

@@ -132,6 +132,7 @@ target_link_libraries(
   velox_type
   velox_vector
   velox_vector_fuzzer
+  velox_window
   Boost::atomic
   Boost::context
   Boost::date_time

velox/exec/tests/WindowFunctionRegistryTest.cpp

@@ -17,7 +17,7 @@
 
 #include "velox/exec/WindowFunction.h"
 #include "velox/expression/SignatureBinder.h"
-#include "velox/type/Type.h"
+#include "velox/functions/prestosql/window/WindowFunctionsRegistration.h"
 
 namespace facebook::velox::exec::test {
 
@@ -107,4 +107,27 @@ TEST_F(WindowFunctionRegistryTest, mixedCaseName) {
       "window_fUNC_alias", {BIGINT(), DOUBLE()}, BIGINT());
 }
 
+TEST_F(WindowFunctionRegistryTest, prefix) {
+  // Remove all functions and check for no entries.
+  exec::windowFunctions().clear();
+  EXPECT_EQ(0, exec::windowFunctions().size());
+
+  // Register without prefix and memorize function maps.
+  window::prestosql::registerAllWindowFunctions();
+  const auto windowFuncMapBase = exec::windowFunctions();
+
+  // Remove all functions and check for no entries.
+  exec::windowFunctions().clear();
+  EXPECT_EQ(0, exec::windowFunctions().size());
+
+  // Register with prefix and check all functions have the prefix.
+  const std::string prefix{"test.abc_schema."};
+  window::prestosql::registerAllWindowFunctions(prefix);
+  auto& windowFuncMap = exec::windowFunctions();
+  for (const auto& entry : windowFuncMap) {
+    EXPECT_EQ(prefix, entry.first.substr(0, prefix.size()));
+    EXPECT_EQ(1, windowFuncMapBase.count(entry.first.substr(prefix.size())));
+  }
+}
+
 } // namespace facebook::velox::exec::test

velox/functions/prestosql/window/tests/CMakeLists.txt

@@ -58,14 +58,3 @@ add_test(
 
 target_link_libraries(velox_windows_agg_test
                       ${CMAKE_WINDOW_TEST_LINK_LIBRARIES})
-
-add_executable(velox_windows_util_test WindowFunctionRegTest.cpp
-                                       ${CMAKE_WINDOW_TEST_MAIN_FILES})
-
-add_test(
-  NAME velox_windows_util_test
-  COMMAND velox_windows_util_test
-  WORKING_DIRECTORY .)
-
-target_link_libraries(velox_windows_util_test
-                      ${CMAKE_WINDOW_TEST_LINK_LIBRARIES})