[3] Expose media similarity in ListArticles #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose similarity calculated by media manager in ArticleConnnection edge
- Ref: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-count.html#search-count-request-body - Also adds console.error that prints the whole error message to aid debugging
- Correctly connect scripted field to GraphQL output
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 30, 2023
Merged
MrOrz
changed the title
bil4444
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development, we found that actually it is possible for pure text to have score > 100
.
In this PR, we expose MediaManager's similarity in the
edgeofListArticles, so that clients like LINE bot don't need to rely on score to determine if there is a matching, similar image / video / etc file.Refactors: