Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add non-null to common types' fields #320

Merged
merged 1 commit into from
Oct 18, 2023
Merged

refactor: add non-null to common types' fields #320

merged 1 commit into from
Oct 18, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 8, 2023

Make GraphQL return types more strict so that clients can have less null checks.

Range: Article, Reply, ArticleReply

@MrOrz MrOrz self-assigned this Oct 8, 2023
@coveralls
Copy link

Coverage Status

coverage: 88.397% (-0.1%) from 88.504% when pulling c3d3a1b on non-nulls into 5946237 on master.

@MrOrz MrOrz marked this pull request as ready for review October 9, 2023 11:23
@MrOrz MrOrz merged commit 0263d29 into master Oct 18, 2023
3 checks passed
@MrOrz MrOrz deleted the non-nulls branch October 18, 2023 17:47
@MrOrz MrOrz mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

@andyy0216 andyy0216 Awaiting requested review from andyy0216

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrOrz @coveralls @bil4444