Skip to content

Commit

Permalink
Merge pull request #208 from cofacts/string-update
Browse files Browse the repository at this point in the history
Update translation to avoid interpolation error
  • Loading branch information
MrOrz authored Jul 9, 2020
2 parents ecef237 + cbe9062 commit 4b3dd66
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 10 deletions.
34 changes: 27 additions & 7 deletions i18n/zh_TW.po
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,6 @@ msgstr "查看回報的訊息"
msgid "We've received feedback from you and ${ _otherFeedbackCount } other users!"
msgstr "感謝您與其他 ${_otherFeedbackCount} 人的評價。"

#: src/webhook/handlers/askingReplyFeedback.js:160
#, javascript-format
msgid "If you have a better reply, feel free to submit it to ${ _articleUrl } ."
msgstr "若您認為自己能回應得更好,歡迎到 ${ _articleUrl } 提交新的回應唷!"

#: src/webhook/handlers/askingReplyFeedback.js:165
msgid "Please press the latest button to provide feedback to reply."
msgstr "請用最近的按鈕來評價此回應。"
Expand Down Expand Up @@ -380,7 +375,7 @@ msgstr "請幫我看看這是真的還是假的:${ articleUrl }"

#: src/webhook/handlers/utils.js:271
msgid "Share on Facebook"
msgstr "就教臉書大神"
msgstr "請教臉書大神"

#: src/webhook/handlers/utils.js:275
#. t: Facebook hash tag
Expand Down Expand Up @@ -602,4 +597,29 @@ msgstr "上一頁"

#: src/liff/components/Pagination.svelte:26
msgid "Next"
msgstr "下一頁"
msgstr "下一頁"

#: src/liff/pages/UserSetting.svelte:25
msgid "Use line notify"
msgstr ""

#: src/liff/pages/UserSetting.svelte:29
msgid "Use push message"
msgstr ""

#: src/liff/pages/UserSetting.svelte:75
msgid "Settings"
msgstr ""

#: src/liff/pages/UserSetting.svelte:76
msgid "Notification"
msgstr ""

#: src/liff/pages/UserSetting.svelte:78
msgid "Not available"
msgstr ""

#: src/webhook/handlers/askingReplyFeedback.js:160
#, javascript-format
msgid "If you have a better reply, feel free to submit it to ${ submissionUrl } ."
msgstr "若您認為自己能回應得更好,歡迎到 ${ submissionUrl } 提交新的回應唷!"
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"build:liff": "NODE_ENV=production webpack",
"lint:fix": "eslint --fix .",
"lint": "eslint .",
"preliff": "bash build-liff.sh",
"i18n:extract": "ttag update i18n/zh_TW.po src/",
"i18n:validate": "ttag validate i18n/zh_TW.po",
"clean": "run-s clean:*",
Expand Down
4 changes: 2 additions & 2 deletions src/webhook/handlers/askingReplyFeedback.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export default async function askingReplyFeedback(params) {
{ userId }
);

const articleUrl = getArticleURL(data.selectedArticleId);
const submissionUrl = getArticleURL(data.selectedArticleId);
const otherFeedbackCount = updatedArticleReply.feedbackCount - 1;

replies = [
Expand All @@ -157,7 +157,7 @@ export default async function askingReplyFeedback(params) {
},
{
type: 'text',
text: `💁 ${t`If you have a better reply, feel free to submit it to ${articleUrl} .`}`,
text: `💁 ${t`If you have a better reply, feel free to submit it to ${submissionUrl} .`}`,
},
];
} else {
Expand Down

0 comments on commit 4b3dd66

Please sign in to comment.