Initial implementation of LineChart #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
reviewed
Aug 17, 2020
|
Thanks a lot for the feedback! I'm marking this as WIP and will hold off until we get confirmation on the design. |
|
|
MrOrz
reviewed
Sep 2, 2020
MrOrz
reviewed
Sep 2, 2020
MrOrz
requested changes
Sep 6, 2020
|
Recently I have rolled back apollo client to version 2. Please also rebase the PR and change apollo-client 3 dependencies accordingly. More specifically,
|
MrOrz
approved these changes
Sep 7, 2020
| const ticks = getTicks(scale, roundFn, tickNum); | ||
| return ticks.map((tick, i) => ( | ||
| <TickGroup | ||
| key={`${tick - 0}_${i}`} |
There was a problem hiding this comment.
tick could be a number or a date, -0 remains the same if it's a number and converts date into epoch seconds otherwise.
it's not necessary, just makes the key look cleaner
There was a problem hiding this comment.
I see. We could use unary + to convert things to number, it's shorter ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR to feature branch instead of
devbecause it's still a work in progress, and blocked by designs.However, I would like to check with you and see if the current implementation aligns with the current coding style/standard before moving further, as we have discussed a few times about how to integrate
d3withReact.