Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback when terms fail to load #558

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Add fallback when terms fail to load #558

merged 3 commits into from
Jan 10, 2024

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jan 10, 2024

Terms page

  • Loading page also link to Terms in case loading stuck
  • When loading fails, provide link to Terms
load-user-agg.mp4

Footer adjustments

  • Show all footer content on mobile so that terms of use is also available
  • Distribute width of columns in footer using longest content

image
image

MrOrz added 3 commits January 10, 2024 13:17
@MrOrz
feat(pages): fallback to link to terms on Github
fd5271c 
- Facebook terms checker sometimes fail to load terms for unknown reasons
@MrOrz
fix(components): AppFooter always show full content
e681250
@MrOrz
fix(components): adjust footer columns to distribute space in between
b430006 
- so that columns don't go too left visually
@coveralls
Copy link

coveralls commented Jan 10, 2024 •
edited
Loading

Coverage Status

coverage: 76.218%. remained the same
when pulling b430006 on terms-fallback
into 20083e3 on master.

@MrOrz MrOrz marked this pull request as ready for review January 10, 2024 05:43
@MrOrz MrOrz self-assigned this Jan 10, 2024
nonumpa
nonumpa approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrOrz MrOrz merged commit 87f90c8 into master Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@andyy0216 andyy0216 andyy0216 approved these changes

@nonumpa nonumpa nonumpa approved these changes

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrOrz @coveralls @nonumpa @andyy0216 @bil4444