Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feedbacks aren't sorted as expected #581

Merged
merged 2 commits into from
Nov 24, 2024
Merged

fix: feedbacks aren't sorted as expected #581

merged 2 commits into from
Nov 24, 2024

Conversation

belong112
Copy link
Contributor

截圖 2024-11-23 下午3 15 41

feedbacks with comments are sorted in the front

@coveralls
Copy link

coveralls commented Nov 23, 2024 •
edited
Loading

Coverage Status

coverage: 71.733% (+0.4%) from 71.353%
when pulling 3ab9495 on belong112:master
into 17038be on cofacts:master.

MrOrz
MrOrz reviewed Nov 23, 2024
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you so much for looking into this issue! I have some comments on the PR. Would you make further changes on the PR, or would you prefer me to do the changes instead?

components/ArticleReplyFeedbackControl/ReasonsDisplay.js Outdated Show resolved Hide resolved
components/ArticleReplyFeedbackControl/ReasonsDisplay.js Outdated Show resolved Hide resolved
components/ArticleReplyFeedbackControl/ReasonsDisplay.js Outdated Show resolved Hide resolved
@belong112
Copy link
Contributor Author

Hello, thank you so much for looking into this issue! I have some comments on the PR. Would you make further changes on the PR, or would you prefer me to do the changes instead?

Sure, thanks for reviewing and giving comments !

@belong112
Copy link
Contributor Author

Modified, please check~

@MrOrz MrOrz linked an issue Nov 24, 2024 that may be closed by this pull request
New feedbacks are not shown in reason popup when there are too many feedbacks #554
Closed
@MrOrz MrOrz merged commit 617e79a into cofacts:master Nov 24, 2024
1 check passed
@johnson-liang johnson-liang mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New feedbacks are not shown in reason popup when there are too many feedbacks
3 participants
@belong112 @coveralls @MrOrz