Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feedbacks were not sorted correctly #583

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: feedbacks were not sorted correctly #583

merged 1 commit into from
Nov 25, 2024

Conversation

belong112
Copy link
Contributor

feedbacks with comment should be sorted to the front
螢幕擷取畫面 2024-11-25 153255

@belong112 belong112 changed the title fix: fix feedback sorting fix: feedbacks were not sorted correctly Nov 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 71.733%. remained the same
when pulling 3131d04 on belong112:master
into 617e79a on cofacts:master.

MrOrz
MrOrz approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Let me deploy it to staging and take a look

@MrOrz MrOrz merged commit 111cc23 into cofacts:master Nov 25, 2024
2 checks passed
@MrOrz MrOrz linked an issue Nov 25, 2024 that may be closed by this pull request
New feedbacks are not shown in reason popup when there are too many feedbacks #554
Closed
@MrOrz MrOrz mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New feedbacks are not shown in reason popup when there are too many feedbacks
3 participants
@belong112 @coveralls @MrOrz