Implement conversion from LDK route to Barq Route Output #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raehat
force-pushed
the
ldk-route-to-barq-output
branch
2 times, most recently
from
3257340 to
914019b
Compare
vincenzopalazzo
requested changes
Jul 31, 2024
|
|
||
| unimplemented!("convert_route_to_output not implemented yet.") | ||
| // TODO: Implement the logic to convert the LDK Route to RouteOutput |
There was a problem hiding this comment.
it is not already implemented with this code?
| hop.pubkey.to_string(), | ||
| hop.short_channel_id.to_string(), | ||
| hop.cltv_expiry_delta, | ||
| hop.fee_msat, |
There was a problem hiding this comment.
in core lightning the amount_msat is the fee_msat?
There was a problem hiding this comment.
in fact, this is wrong, from core lightning docs amount_msat (msat): The amount expected by the node at the end of this hop.
There was a problem hiding this comment.
pay attention to this because we are playing with people money
raehat
force-pushed
the
ldk-route-to-barq-output
branch
from
914019b to
3ae8daf
Compare
|
This branch is not well-tested. Current test cases only cover the direct strategy, not the probabilistic strategy. Once test cases are written for the probabilistic strategy and they pass, only then will this PR be ready to merge. |
vincenzopalazzo
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29 (comment)