fix(lib): simplify and improve sh! macro #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coffee-docs canceled.
|
| } | ||
| return Err(CoffeeError::new(2, &content)); | ||
| let mut cmd = Command::new("sh"); | ||
| cmd.args(&["-c", &script]); |
|
@jackstar12 Are you still working on this? I would really love to merge went he review is addressed |
yes, I was on vacation this week, I`ll get to it in the next few days |
instead of trying to manually parse the script and potentially making errors, let the actual `sh` command do the work correctly
jackstar12
force-pushed
the
macros/simplfy_sh
branch
from
361a5db to
785e8ac
Compare
vincenzopalazzo
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Thanks for working on this and fixing my bad sh macros!
ACK 785e8ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on #194 I noticed a issue with the
shmacro when trying to execute a script that uses a pipe. Looking into the implementation I saw that it tries to manually parse out the commands, which is pretty error prone. so, instead of trying to manually parse the script and potentially making errors, let the actualshcommand do the work correctly