Always print install errors #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for coffee-docs canceled.
|
daywalker90
force-pushed
the
show-install-error
branch
from
aabb153 to
dbf2c9f
Compare
vincenzopalazzo
requested changes
Feb 26, 2024
daywalker90
force-pushed
the
show-install-error
branch
from
dbf2c9f to
7e28344
Compare
vincenzopalazzo
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
coffee installand there is an error e.g. the plugin could not be started by cln, coffee does not print an error. Not even inverbosemode. Only with theRUST_LOGenv you can eventually see what happens. I propose to always show an install error to the user who just follows the documentation.