Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support important plugins #252

Merged

Conversation

daywalker90
Copy link
Collaborator

added a new manifest field to mark plugin as important and only install it as static and important

part of #245

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for coffee-docs canceled.

Name Link
🔨 Latest commit 8075ac8
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/65e1c2395e14420007629438

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one commit and we are ready to go, thanks

coffee_lib/src/plugin.rs Outdated Show resolved Hide resolved
added a new manifest field to mark plugin as important
only install as static and important

part of coffee-tools#245
@daywalker90 daywalker90 force-pushed the important-plugin-support branch from 62c8fa0 to 8075ac8 Compare March 1, 2024 11:55
@daywalker90
Copy link
Collaborator Author

rebased and implemented suggestion

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vincenzopalazzo vincenzopalazzo merged commit f4208f9 into coffee-tools:master Mar 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants