-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coffee unlink
Command
#279
Conversation
- Rename `coffee setup` command to `coffee link` - Change function names from `setup_*` to `link_*` (e.g., `setup_with_cln` to `link_with_cln`) - Update command references in `httpd` and `plugin` crates - Modify relevant documentation to reflect the command name change This refactor is to accommodate the addition of a new `unlink` command. Signed-off-by: Tarek <[email protected]>
- Add methods in `coffee_core` to enable unlinking coffee configuration from CLN configuration - Update `coffee_cmd` crate to support the new `unlink` command - Add documentation for the new `unlink` command Note: The `clightningrpc-conf` from git is required to use the `rm_subconf()` method. Signed-off-by: Tarek <[email protected]>
✅ Deploy Preview for coffee-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 20be671
Thanks!
ops CI shows a break
|
Hmmm Update Let me investigate this further |
Signed-off-by: Tarek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c3f842c
Description
This pull request adds the
coffee unlink
command and renames thecoffee setup
command tocoffee link
.Fixes #278
Changes
setup
Command tolink
setup_*
tolink_*
(e.g.,setup_with_cln
tolink_with_cln
)httpd
andplugin
cratescoffee unlink
Commandcoffee_core
to enable unlinking coffee configuration from CLN configurationcoffee_cmd
crate to include the newunlink
commandunlink
commandNote: The commits are organized so that the renaming of
coffee setup
is in one commit, and the addition ofcoffee unlink
is in a separate commit. Theclightningrpc-conf
from git is required to use therm_subconf()
method.