-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing assert statements with Exceptions #137
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 95.95% 91.89% -4.06%
==========================================
Files 29 29
Lines 1656 1752 +96
Branches 255 330 +75
==========================================
+ Hits 1589 1610 +21
- Misses 35 76 +41
- Partials 32 66 +34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @jezsadler for these super useful changes. I'm going to give the team one last chance to object during the call today and then merge this.
Replaced assert statements across several files with ValueError or TypeError messages, which should be more informative.
Included unit tests for many of these - some of the error states were difficult to induce.
Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.